Skip to content

feature-wisun: Add fix for STM32F4 hardfault in sleep mode #12726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

feature-wisun: Add fix for STM32F4 hardfault in sleep mode #12726

merged 2 commits into from
Apr 1, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Mar 31, 2020

Summary of changes

Same fix as for Mbed OS 6.0.0-beta1, #12662. Cherry-picked for feature-wisun branch.

This fix follows what https://www.st.com/resource/en/errata_sheet/dm00037591-stm32f405-407xx-and-stm32f415-417xx-device-limitations-stmicroelectronics.pdf errata states.

This PR also reverts the commit originally made to disable the sleep mode.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-mesh , @teetak01 , @TuomoHautamaki

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

As CI was blocked by couple of issues yesterday, I am trying now to schedule 5.15 jobs. If this is urgent, let me know to get it in, otherwise would schedule it later today to run overnight.

@teetak01
Copy link
Contributor

teetak01 commented Mar 31, 2020 •
edited
Loading

It would be good to get this in quickly, as we need to run some long-running tests after this.

@0xc0170 actually this can wait after all. So no rush.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

I scheduled 5.15 job (as its new, it is new config)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

OK will abort, a test takes 4 hours so will get other fixes to 5.15 that should land and this branch can benefit as well

@artokin Probably the best would be to wait for 5.15 fixes landing and rebase the branch then

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

I aborted teh job, wil lrestart later today

@mbed-ci
Copy link

mbed-ci commented Mar 31, 2020

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests-lts
  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts
  • jenkins-ci/mbed-os-ci_build-ARM-lts

@artokin
Copy link
Contributor Author

artokin commented Mar 31, 2020

Sure, this is not urgent as our test cycle has already started with previous version. Please let me know once we can proceed.

@0xc0170 0xc0170 changed the title [feature-wisun] Add fix for STM32F4 hardfault in sleep mode feature-wisun: Add fix for STM32F4 hardfault in sleep mode Mar 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 1, 2020

jenkins-ci/example-test-lts — Error

Not correct for this job, was an old config. I'll merge this to the feature branch.

@0xc0170 0xc0170 merged commit c5c2113 into ARMmbed:feature-wisun Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@JarkkoPaso JarkkoPaso JarkkoPaso approved these changes

@mikter mikter mikter approved these changes

@teetak01 teetak01 teetak01 approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@artokin @0xc0170 @teetak01 @mbed-ci @JarkkoPaso @mikter